Skip to content

Fix qmlformat script for newer Arch - #5229

Open
kairosci wants to merge 3 commits into
wwmm:masterfrom
kairosci:fix-qmlformat
Open

Fix qmlformat script for newer Arch#5229
kairosci wants to merge 3 commits into
wwmm:masterfrom
kairosci:fix-qmlformat

Conversation

@kairosci

@kairosci kairosci commented Aug 7, 2026

Copy link
Copy Markdown

This pull request fixes the failing QML format job by adding a command fallback since the binary location changed on Arch Linux. It also updates the flatpak external data checker configuration for libebur128 to use git tags instead of GitHub releases, avoiding API rate limits that caused the Flatpak lint job to fail.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

@kairosci
kairosci marked this pull request as draft August 7, 2026 12:09
@kairosci
kairosci marked this pull request as ready for review August 7, 2026 12:22
@kairosci

kairosci commented Aug 8, 2026

Copy link
Copy Markdown
Author

@wwmm could you take a look at it? Thanks!

@wwmm

wwmm commented Aug 8, 2026

Copy link
Copy Markdown
Owner

As the scripts and flatpak files being touched were written by @vchernin it would probably be better if he reviewed these changes.

Here on my Arch Linux installation the qml scripts seem fine. Qml's linter does complain about

wallace@wwmm ~/myfiles/code/cpp/easyeffects $ ./util/qmlformat.sh 
Failed to parse src/contents/ui/DelegateClientsList.qml
Failed to parse src/contents/ui/DelegateModulesList.qml
Failed to parse src/contents/ui/DelegateStreamsList.qml

But that looks more like a bug in the linter than in the scripts. Our CI job does fail because of it. But I was waiting for Qt 6.12 before deciding what to do about it.

Sometimes the flatpak external data checker job fails. If that is the better way to fix the problem I don't know.

@vchernin

vchernin commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

The qmllint and qmlformat scripts are hacks to begin with, so any changes to make them more reliable seem fine to me. But clearly distros need to do a better job here if we now have 3 possible binary names…

I would suggest that qmllint-qt6 should be checked before trying qmllint in the conditionals. Same for qmlformat. It seems like a safer option to try the -qt6 option first since it is more explicit.

The fix for the Flatpak job makes a bit of sense but is also a bit puzzling. We should be passing the CI provided GITHUB_TOKEN environment variable and so Flatpak external data checker should only be making authenticated API calls. Those should surely not be hitting any GitHub API limit. But if this indeed works more reliably I guess it’s fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants